From d9b3012153a0c2dfbcf9b309919be7cffb5cd09a Mon Sep 17 00:00:00 2001
From: Daniel-I-Am <djdecloet@gmail.com>
Date: Thu, 2 Sep 2021 12:59:27 +0200
Subject: [PATCH] Only show published items in the popular list

---
 app/Http/Controllers/BlogArticleController.php | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/Http/Controllers/BlogArticleController.php b/app/Http/Controllers/BlogArticleController.php
index 9423546..e658e3e 100644
--- a/app/Http/Controllers/BlogArticleController.php
+++ b/app/Http/Controllers/BlogArticleController.php
@@ -59,13 +59,14 @@ class BlogArticleController extends Controller
      */
     public function popular()
     {
-        $query = BlogArticle::orderBy('views', 'desc')->orderBY('date', 'desc');
+        $data = BlogArticle::select()
+            ->orderBy('views', 'desc')
+            ->orderBy('date', 'desc')
+            ->where('published', true)
+            ->limit(5)
+            ->get()
+        ;
 
-        if (!$this->authService->isAuthenticated()) {
-            $query = $query->where('published', true);
-        }
-
-        $data = $query->limit(5)->get();
         return response()->json($data);
     }