Only show published items in the popular list

2021-09-02 12:59:27 +02:00 · 2021-09-02 12:59:27 +02:00 · d9b3012153
commit d9b3012153
parent e69b7df500
1 changed files with 7 additions and 6 deletions
--- a/app/Http/Controllers/BlogArticleController.php
+++ b/app/Http/Controllers/BlogArticleController.php
@ -59,13 +59,14 @@ class BlogArticleController extends Controller
     */
    public function popular()
    {
-        $query = BlogArticle::orderBy('views', 'desc')->orderBY('date', 'desc');
+        $data = BlogArticle::select()
+            ->orderBy('views', 'desc')
+            ->orderBy('date', 'desc')
+            ->where('published', true)
+            ->limit(5)
+            ->get()
+        ;

-        if (!$this->authService->isAuthenticated()) {
-            $query = $query->where('published', true);
-        }
-
-        $data = $query->limit(5)->get();
        return response()->json($data);
    }